perf: pass storage to tryFallbackAccounts to skip redundant disk read#22
Open
iceteaSA wants to merge 1 commit into
Open
perf: pass storage to tryFallbackAccounts to skip redundant disk read#22iceteaSA wants to merge 1 commit into
iceteaSA wants to merge 1 commit into
Conversation
The fetch handler already loads storage at the start of every request. tryFallbackAccounts was reloading it from disk unnecessarily. Now accepts an optional existingStorage parameter to reuse the caller's copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
existingStorageparameter totryFallbackAccounts(). The fetch handler loads storage at the start of every request buttryFallbackAccountswas reloading it from disk unnecessarily.Companion to #19 which does the same for
getUsableFallbackAccounts.Testing
All 214 tests pass. No behavior change — only avoids redundant disk I/O.